Update test based on new PullImage CRI.

Signed-off-by: Haiyan Meng <haiyanmeng@google.com>

integration/addition_gids_test.go

@@ -48,7 +48,7 @@ func TestAdditionalGids(t *testing.T) {
 		containerName = "test-container"
 	)
 	t.Logf("Pull test image %q", testImage)
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))

integration/container_log_test.go

@@ -51,7 +51,7 @@ func TestContainerLogWithoutTailingNewLine(t *testing.T) {
 		containerName = "test-container"
 	)
 	t.Logf("Pull test image %q", testImage)
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))
@@ -111,7 +111,7 @@ func TestLongContainerLog(t *testing.T) {
 		containerName = "test-container"
 	)
 	t.Logf("Pull test image %q", testImage)
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))

integration/container_stop_test.go

@@ -43,7 +43,7 @@ func TestSharedPidMultiProcessContainerStop(t *testing.T) {
 				containerName = "test-container"
 			)
 			t.Logf("Pull test image %q", testImage)
-			img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+			img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 			require.NoError(t, err)
 			defer func() {
 				assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))

integration/container_without_image_ref_test.go

@@ -40,7 +40,7 @@ func TestContainerLifecycleWithoutImageRef(t *testing.T) {
 		containerName = "test-container"
 	)
 	t.Log("Pull test image")
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))

integration/containerd_image_test.go

@@ -182,8 +182,9 @@ func TestContainerdImageInOtherNamespaces(t *testing.T) {
 	}
 	require.NoError(t, Consistently(checkImage, 100*time.Millisecond, time.Second))
 
+	sbConfig := PodSandboxConfig("sandbox", "test")
 	t.Logf("pull the image into cri plugin")
-	id, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	id, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: id}))

integration/imagefs_info_test.go

@@ -28,15 +28,16 @@ import (
 )
 
 func TestImageFSInfo(t *testing.T) {
+	config := PodSandboxConfig("running-pod", "imagefs")
+
 	t.Logf("Pull an image to make sure image fs is not empty")
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: "busybox"}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: "busybox"}, nil, config)
 	require.NoError(t, err)
 	defer func() {
 		err := imageService.RemoveImage(&runtime.ImageSpec{Image: img})
 		assert.NoError(t, err)
 	}()
 	t.Logf("Create a sandbox to make sure there is an active snapshot")
-	config := PodSandboxConfig("running-pod", "imagefs")
 	sb, err := runtimeService.RunPodSandbox(config, *runtimeHandler)
 	require.NoError(t, err)
 	defer func() {

integration/pod_hostname_test.go

@@ -75,7 +75,7 @@ func TestPodHostname(t *testing.T) {
 				containerName = "test-container"
 			)
 			t.Logf("Pull test image %q", testImage)
-			img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+			img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 			require.NoError(t, err)
 			defer func() {
 				assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))

integration/restart_test.go

@@ -133,7 +133,7 @@ func TestContainerdRestart(t *testing.T) {
 
 	t.Logf("Pull test images")
 	for _, image := range []string{"busybox", "alpine"} {
-		img, err := imageService.PullImage(&runtime.ImageSpec{image}, nil)
+		img, err := imageService.PullImage(&runtime.ImageSpec{image}, nil, nil)
 		require.NoError(t, err)
 		defer func() {
 			assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))
@@ -209,15 +209,16 @@ func TestUnknownStateAfterContainerdRestart(t *testing.T) {
 		t.Skip("unsupported config: runc not in PATH")
 	}
 
+	sbConfig := PodSandboxConfig("sandbox", "sandbox-unknown-state")
+
 	const testImage = "busybox"
 	t.Logf("Pull test image %q", testImage)
-	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	img, err := imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 	defer func() {
 		assert.NoError(t, imageService.RemoveImage(&runtime.ImageSpec{Image: img}))
 	}()
 
-	sbConfig := PodSandboxConfig("sandbox", "sandbox-unknown-state")
 	t.Log("Should not be able to create sandbox without runc")
 	tmpRuncPath := Randomize(runcPath)
 	require.NoError(t, os.Rename(runcPath, tmpRuncPath))

integration/truncindex_test.go

@@ -29,9 +29,11 @@ func genTruncIndex(normalName string) string {
 }
 
 func TestTruncIndex(t *testing.T) {
+	sbConfig := PodSandboxConfig("sandbox", "truncindex")
+
 	t.Logf("Pull an image")
 	const appImage = "busybox"
-	imgID, err := imageService.PullImage(&runtimeapi.ImageSpec{Image: appImage}, nil)
+	imgID, err := imageService.PullImage(&runtimeapi.ImageSpec{Image: appImage}, nil, sbConfig)
 	require.NoError(t, err)
 	imgTruncId := genTruncIndex(imgID)
 	defer func() {
@@ -54,7 +56,6 @@ func TestTruncIndex(t *testing.T) {
 	// TODO(yanxuean): add test case for ListImages
 
 	t.Logf("Create a sandbox")
-	sbConfig := PodSandboxConfig("sandbox", "truncindex")
 	sb, err := runtimeService.RunPodSandbox(sbConfig, *runtimeHandler)
 	require.NoError(t, err)
 	sbTruncIndex := genTruncIndex(sb)

integration/volume_copy_up_test.go

@@ -43,7 +43,7 @@ func TestVolumeCopyUp(t *testing.T) {
 	}()
 
 	t.Logf("Pull test image")
-	_, err = imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	_, err = imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 
 	t.Logf("Create a container with volume-copy-up test image")
@@ -105,7 +105,7 @@ func TestVolumeOwnership(t *testing.T) {
 	}()
 
 	t.Logf("Pull test image")
-	_, err = imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil)
+	_, err = imageService.PullImage(&runtime.ImageSpec{Image: testImage}, nil, sbConfig)
 	require.NoError(t, err)
 
 	t.Logf("Create a container with volume-ownership test image")