github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Fix slice append error

Browse Source 
In golang when copy a slice, if the slice is initialized with a
desired length, then appending to it will cause the size double.

Signed-off-by: bin liu <liubin0329@gmail.com>
This commit is contained in:
bin liu 2022-11-12 00:09:31 +08:00
parent 0f401197c8
commit 0c63c42f81
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/cri/server/helpers.go
View File

@ -474,7 +474,7 @@ func copyResourcesToStatus(spec *runtimespec.Spec, status containerstore.Status)
} }
if spec.Linux.Resources.HugepageLimits != nil { if spec.Linux.Resources.HugepageLimits != nil {
hugepageLimits := make([]*runtime.HugepageLimit, len(spec.Linux.Resources.HugepageLimits)) hugepageLimits := make([]*runtime.HugepageLimit, 0)
for _, l := range spec.Linux.Resources.HugepageLimits { for _, l := range spec.Linux.Resources.HugepageLimits {
hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{ hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{
PageSize: l.Pagesize, PageSize: l.Pagesize,

2
pkg/cri/store/container/status.go
View File

@ -219,7 +219,7 @@ func deepCopyOf(s Status) Status {
} }
copy.Resources = &runtime.ContainerResources{} copy.Resources = &runtime.ContainerResources{}
if s.Resources != nil && s.Resources.Linux != nil { if s.Resources != nil && s.Resources.Linux != nil {
hugepageLimits := make([]*runtime.HugepageLimit, len(s.Resources.Linux.HugepageLimits)) hugepageLimits := make([]*runtime.HugepageLimit, 0)
for _, l := range s.Resources.Linux.HugepageLimits { for _, l := range s.Resources.Linux.HugepageLimits {
hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{ hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{
PageSize: l.PageSize, PageSize: l.PageSize,