Add NoSameOwner option when unpacking tars

When unpacking a TAR archive, containerd preserves file's owner:
https://github.com/containerd/containerd/blob/main/archive/tar.go#L384

In some cases this behavior is not desired. In current implementation we
avoid `Lchown` on Windows. Another case when this should be skipped is
when using native snapshotter on darwin and running as non-root user.

This PR extracts a generic option - `WithNoSameOwner` (same as
`tar --no-same-owner`) to skip `Lchown` when its not required.

Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
This commit is contained in:
Maksym Pavlenko
2022-09-09 15:46:18 -07:00
parent f4a905109b
commit 0f51aa874d
6 changed files with 42 additions and 12 deletions

View File

@@ -43,7 +43,7 @@ func TestPrefixHeaderReadable(t *testing.T) {
t.Fatal(err)
}
defer r.Close()
_, err = Apply(context.Background(), tmpDir, r)
_, err = Apply(context.Background(), tmpDir, r, WithNoSameOwner())
if err != nil {
t.Fatal(err)
}