From 1607a9e0ca49ed85ab2efb09ae30288814a80620 Mon Sep 17 00:00:00 2001 From: Christy Perez Date: Tue, 12 Dec 2017 15:52:11 -0600 Subject: [PATCH] check for threshold, not range This test seems to fall apart on a loaded system. In actuality it doesn't seem to be testing for a threshold, but a "sane" range. Signed-off-by: Christy Perez --- gc/scheduler/scheduler_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gc/scheduler/scheduler_test.go b/gc/scheduler/scheduler_test.go index 180e4b02c..103dc7f2a 100644 --- a/gc/scheduler/scheduler_test.go +++ b/gc/scheduler/scheduler_test.go @@ -10,6 +10,7 @@ import ( ) func TestPauseThreshold(t *testing.T) { + cfg := &config{ // With 100μs, gc should run about every 5ms PauseThreshold: 0.02, @@ -39,8 +40,9 @@ func TestPauseThreshold(t *testing.T) { }() time.Sleep(time.Millisecond * 15) - if c := tc.runCount(); c < 3 || c > 4 { - t.Fatalf("unexpected gc run count %d, expected between 5 and 6", c) + + if c := tc.runCount(); c > 4 { + t.Fatalf("unexpected gc run count %d, expected less than 5", c) } }