github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #8225 from AkihiroSuda/comment-image-created-at

Browse Source 
metadata: add comments about `Image.CreatedAt`
This commit is contained in:
Kazuyoshi Kato 2023-03-07 11:28:22 -08:00 committed by GitHub
commit 13bd93847d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
metadata/images.go
View File

@ -145,6 +145,10 @@ func (s *imageStore) Create(ctx context.Context, image images.Image) (images.Ima
return fmt.Errorf("image %q: %w", image.Name, errdefs.ErrAlreadyExists) return fmt.Errorf("image %q: %w", image.Name, errdefs.ErrAlreadyExists)
} }
// The value of `image.CreatedAt` passed from the caller is discarded here.
// Ideally we should return an error when the value is already set.
// However, as `image.CreatedAt` is defined as a non-pointer `time.Time`, we can't compare it to nil.
// And we can't compare it to `time.Time{}` either, as `time.Time{}` is a proper timestamp (1970-01-01 00:00:00).
if tm := epoch.FromContext(ctx); tm != nil { if tm := epoch.FromContext(ctx); tm != nil {
image.CreatedAt = tm.UTC() image.CreatedAt = tm.UTC()
} else { } else {