github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

check for threshold, not range

Browse Source 
This test seems to fall apart on a loaded system. In actuality it
doesn't seem to be testing for a threshold, but a "sane" range.

Signed-off-by: Christy Perez <christy@linux.vnet.ibm.com>
This commit is contained in:
Christy Perez 2017-12-12 15:52:11 -06:00
parent 03bc5e974d
commit 1607a9e0ca
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gc/scheduler/scheduler_test.go
View File

@ -10,6 +10,7 @@ import (
) )
func TestPauseThreshold(t *testing.T) { func TestPauseThreshold(t *testing.T) {
cfg := &config{ cfg := &config{
// With 100μs, gc should run about every 5ms // With 100μs, gc should run about every 5ms
PauseThreshold: 0.02, PauseThreshold: 0.02,
@ -39,8 +40,9 @@ func TestPauseThreshold(t *testing.T) {
}() }()
time.Sleep(time.Millisecond * 15) time.Sleep(time.Millisecond * 15)
if c := tc.runCount(); c < 3 || c > 4 {
t.Fatalf("unexpected gc run count %d, expected between 5 and 6", c) if c := tc.runCount(); c > 4 {
t.Fatalf("unexpected gc run count %d, expected less than 5", c)
} }
} }