github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

script/setup: use git clone instead of go get -d

Browse Source 
`go get -d` uses go modules by default in Go 1.16 and up, which results
in modules being fetched for the "latest" module version, after which we
tried to "git checkout" to `<VERSION>`.

For runc, this means that (possibly incorrectly), `go get` will download
runc `v0.1.1` (most recent non-"pre-release", which caused failures (e.g
the old `Sirupsen/logrus` being downloaded).

In addition, some of the dependencies we're installing use vendoring, and
thus would not require the modules to be downloaded (and vendored files
will be ignored when using `go get` with modules).

This patch switches several uses `go get -d` to use a regular
git clone, after which the desired version is checked out,
and the binaries are built.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Phil Estes <estesp@amazon.com>
This commit is contained in:
Sebastiaan van Stijn
2021-02-05 13:50:07 +01:00
committed by Phil Estes
parent 5f2d02adc5
commit 164573897c
4 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
script/setup/install-critools
View File

@@ -23,9 +23,10 @@ set -eu -o pipefail
cd "$GOPATH"
go get -u github.com/onsi/ginkgo/ginkgo
CRITEST_COMMIT=0f5f734a7e1da0979915c6e7d5b6641bd9dc2627
go get -d github.com/kubernetes-sigs/cri-tools/...
git clone https://github.com/kubernetes-sigs/cri-tools.git "$GOPATH"/src/github.com/kubernetes-sigs/cri-tools
cd "$GOPATH"/src/github.com/kubernetes-sigs/cri-tools
git checkout $CRITEST_COMMIT
git checkout "$CRITEST_COMMIT"
make
make install -e BINDIR=${DESTDIR:=''}/usr/local/bin
cat << EOF | tee ${DESTDIR}/etc/crictl.yaml