github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Fix CI lint error

Browse Source 
Signed-off-by: Jin Dong <djdongjin95@gmail.com>
(cherry picked from commit c8effff1a823bed757194584a80a043c3a69da1a)
This commit is contained in:
Jin Dong 2025-03-18 01:16:07 +00:00 committed by Krisztian Litkey
parent 1a43cb6a10
commit 16f20abdff
No known key found for this signature in database
GPG Key ID: 637F2939D50AF85D
2 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/oci/spec_opts.go
View File

@ -595,13 +595,13 @@ func WithUser(userstr string) SpecOpts {
setProcess(s)
s.Process.User.AdditionalGids = nil
// While the Linux kernel allows the max UID to be MaxUint32 - 2,
// and the OCI Runtime Spec has no definition about the max UID,
// the runc implementation is known to require the UID to be <= MaxInt32.
//
// containerd follows runc's limitation here.
//
// In future we may relax this limitation to allow MaxUint32 - 2,
// or, amend the OCI Runtime Spec to codify the implementation limitation.
// and the OCI Runtime Spec has no definition about the max UID,
// the runc implementation is known to require the UID to be <= MaxInt32.
//
// containerd follows runc's limitation here.
//
// In future we may relax this limitation to allow MaxUint32 - 2,
// or, amend the OCI Runtime Spec to codify the implementation limitation.
const (
minUserID = 0
maxUserID = math.MaxInt32

1
pkg/oci/spec_opts_linux_test.go
View File

@ -105,7 +105,6 @@ guest:x:100:guest
},
}
for _, testCase := range testCases {
testCase := testCase
t.Run(testCase.user, func(t *testing.T) {
t.Parallel()
s := Spec{