Merge pull request #8051 from yulng/goroutine
fix: 'go routine' should be 'goroutine'
This commit is contained in:
commit
179f00c883
@ -64,7 +64,7 @@ func (c *criService) portForward(ctx context.Context, id string, port int32, str
|
|||||||
// golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs) by default in 1.12
|
// golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs) by default in 1.12
|
||||||
// It means that if a host resolves to both IPv6 and IPv4, it will try to connect to any
|
// It means that if a host resolves to both IPv6 and IPv4, it will try to connect to any
|
||||||
// of those addresses and use the working connection.
|
// of those addresses and use the working connection.
|
||||||
// However, the implementation uses go routines to start both connections in parallel,
|
// However, the implementation uses goroutines to start both connections in parallel,
|
||||||
// and this cases that the connection is done outside the namespace, so we try to connect
|
// and this cases that the connection is done outside the namespace, so we try to connect
|
||||||
// serially.
|
// serially.
|
||||||
// We try IPv4 first to keep current behavior and we fallback to IPv6 if the connection fails.
|
// We try IPv4 first to keep current behavior and we fallback to IPv6 if the connection fails.
|
||||||
|
@ -64,7 +64,7 @@ func (c *criService) portForward(ctx context.Context, id string, port int32, str
|
|||||||
// golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs) by default in 1.12
|
// golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs) by default in 1.12
|
||||||
// It means that if a host resolves to both IPv6 and IPv4, it will try to connect to any
|
// It means that if a host resolves to both IPv6 and IPv4, it will try to connect to any
|
||||||
// of those addresses and use the working connection.
|
// of those addresses and use the working connection.
|
||||||
// However, the implementation uses go routines to start both connections in parallel,
|
// However, the implementation uses goroutines to start both connections in parallel,
|
||||||
// and this cases that the connection is done outside the namespace, so we try to connect
|
// and this cases that the connection is done outside the namespace, so we try to connect
|
||||||
// serially.
|
// serially.
|
||||||
// We try IPv4 first to keep current behavior and we fallback to IPv6 if the connection fails.
|
// We try IPv4 first to keep current behavior and we fallback to IPv6 if the connection fails.
|
||||||
|
@ -46,7 +46,7 @@ type Init struct {
|
|||||||
initState initState
|
initState initState
|
||||||
|
|
||||||
// mu is used to ensure that `Start()` and `Exited()` calls return in
|
// mu is used to ensure that `Start()` and `Exited()` calls return in
|
||||||
// the right order when invoked in separate go routines.
|
// the right order when invoked in separate goroutines.
|
||||||
// This is the case within the shim implementation as it makes use of
|
// This is the case within the shim implementation as it makes use of
|
||||||
// the reaper interface.
|
// the reaper interface.
|
||||||
mu sync.Mutex
|
mu sync.Mutex
|
||||||
|
Loading…
Reference in New Issue
Block a user