Add unconvert linter

This linter checks for unnecessary type convertions.

Some convertions are whitelisted because their type is different
on 32bit platforms

Signed-off-by: Daniel Nephin <dnephin@gmail.com>
This commit is contained in:
Daniel Nephin
2018-01-08 17:24:43 -05:00
parent 50a6c62492
commit 184bc25629
14 changed files with 42 additions and 30 deletions

View File

@@ -73,9 +73,9 @@ func adaptPlugin(o interface{}) filters.Adaptor {
switch fieldpath[0] {
case "type":
return string(obj.Type), len(obj.Type) > 0
return obj.Type, len(obj.Type) > 0
case "id":
return string(obj.ID), len(obj.ID) > 0
return obj.ID, len(obj.ID) > 0
case "platforms":
// TODO(stevvooe): Another case here where have multiple values.
// May need to refactor the filter system to allow filtering by