test: use T.TempDir to create temporary test directory
The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
@@ -65,15 +65,9 @@ func TestEnsureRemoveAllWithMount(t *testing.T) {
|
||||
t.Skip("skipping test that requires root")
|
||||
}
|
||||
|
||||
dir1, err := os.MkdirTemp("", "test-ensure-removeall-with-dir1")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
dir2, err := os.MkdirTemp("", "test-ensure-removeall-with-dir2")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
defer os.RemoveAll(dir2)
|
||||
var err error
|
||||
dir1 := t.TempDir()
|
||||
dir2 := t.TempDir()
|
||||
|
||||
bindDir := filepath.Join(dir1, "bind")
|
||||
if err := os.MkdirAll(bindDir, 0755); err != nil {
|
||||
|
||||
@@ -492,10 +492,7 @@ func TestEnsureRemoveAllNotExist(t *testing.T) {
|
||||
}
|
||||
|
||||
func TestEnsureRemoveAllWithDir(t *testing.T) {
|
||||
dir, err := os.MkdirTemp("", "test-ensure-removeall-with-dir")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
dir := t.TempDir()
|
||||
if err := ensureRemoveAll(context.Background(), dir); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
@@ -93,11 +93,9 @@ func TestUpdateRuntimeConfig(t *testing.T) {
|
||||
},
|
||||
} {
|
||||
t.Run(name, func(t *testing.T) {
|
||||
testDir, err := os.MkdirTemp(os.TempDir(), "test-runtime-config")
|
||||
require.NoError(t, err)
|
||||
defer os.RemoveAll(testDir)
|
||||
testDir := t.TempDir()
|
||||
templateName := filepath.Join(testDir, "template")
|
||||
err = os.WriteFile(templateName, []byte(testTemplate), 0666)
|
||||
err := os.WriteFile(templateName, []byte(testTemplate), 0666)
|
||||
require.NoError(t, err)
|
||||
confDir := filepath.Join(testDir, "net.d")
|
||||
confName := filepath.Join(confDir, cniConfigFileName)
|
||||
|
||||
@@ -114,9 +114,7 @@ func TestStatus(t *testing.T) {
|
||||
assert := assertlib.New(t)
|
||||
require := requirelib.New(t)
|
||||
|
||||
tempDir, err := os.MkdirTemp(os.TempDir(), "status-test")
|
||||
require.NoError(err)
|
||||
defer os.RemoveAll(tempDir)
|
||||
tempDir := t.TempDir()
|
||||
statusFile := filepath.Join(tempDir, "status")
|
||||
|
||||
t.Logf("simple store and get")
|
||||
|
||||
Reference in New Issue
Block a user