github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #8077 from Fish-pro/chore/httpvar

Browse Source 
chore: use http constants instead of string
This commit is contained in:
Maksym Pavlenko
2023-02-09 23:32:17 -08:00
committed by GitHub
parent 676b942fef 76a62e52ae
commit 195eca1d6c
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/ctr/commands/pprof/pprof.go
View File

@@ -225,7 +225,7 @@ func httpGetRequest(client *http.Client, request string) (io.ReadCloser, error)
if err != nil { if err != nil {
return nil, err return nil, err
} }
if resp.StatusCode != 200 { if resp.StatusCode != http.StatusOK {
resp.Body.Close() resp.Body.Close()
return nil, fmt.Errorf("http get failed with status: %s", resp.Status) return nil, fmt.Errorf("http get failed with status: %s", resp.Status)
} }

4
remotes/docker/auth/fetch.go
View File

@@ -114,7 +114,7 @@ func FetchTokenWithOAuth(ctx context.Context, client *http.Client, headers http.
form.Set("access_type", "offline") form.Set("access_type", "offline")
} }
req, err := http.NewRequestWithContext(ctx, "POST", to.Realm, strings.NewReader(form.Encode())) req, err := http.NewRequestWithContext(ctx, http.MethodPost, to.Realm, strings.NewReader(form.Encode()))
if err != nil { if err != nil {
return nil, err return nil, err
} }
@@ -161,7 +161,7 @@ type FetchTokenResponse struct {
// FetchToken fetches a token using a GET request // FetchToken fetches a token using a GET request
func FetchToken(ctx context.Context, client *http.Client, headers http.Header, to TokenOptions) (*FetchTokenResponse, error) { func FetchToken(ctx context.Context, client *http.Client, headers http.Header, to TokenOptions) (*FetchTokenResponse, error) {
req, err := http.NewRequestWithContext(ctx, "GET", to.Realm, nil) req, err := http.NewRequestWithContext(ctx, http.MethodGet, to.Realm, nil)
if err != nil { if err != nil {
return nil, err return nil, err
} }