github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #5206 from Iceber/fix-new-container

Browse Source 
runtime/v2/runc: fix the defer cleanup of the NewContainer
This commit is contained in:
Fu, Wei 2021-03-17 12:11:45 +08:00 committed by GitHub
commit 1a0973dde3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
runtime/v2/runc/container.go
View File

@ -42,7 +42,7 @@ import (
) )
// NewContainer returns a new runc container // NewContainer returns a new runc container
func NewContainer(ctx context.Context, platform stdio.Platform, r *task.CreateTaskRequest) (*Container, error) { func NewContainer(ctx context.Context, platform stdio.Platform, r *task.CreateTaskRequest) (_ *Container, retErr error) {
ns, err := namespaces.NamespaceRequired(ctx) ns, err := namespaces.NamespaceRequired(ctx)
if err != nil { if err != nil {
return nil, errors.Wrap(err, "create namespace") return nil, errors.Wrap(err, "create namespace")
@ -97,9 +97,9 @@ func NewContainer(ctx context.Context, platform stdio.Platform, r *task.CreateTa
return nil, err return nil, err
} }
defer func() { defer func() {
if err != nil { if retErr != nil {
if err2 := mount.UnmountAll(rootfs, 0); err2 != nil { if err := mount.UnmountAll(rootfs, 0); err != nil {
logrus.WithError(err2).Warn("failed to cleanup rootfs mount") logrus.WithError(err).Warn("failed to cleanup rootfs mount")
} }
} }
}() }()