From 1b65fe26461561a0c1fde6c3344a8cf1539c96d8 Mon Sep 17 00:00:00 2001 From: rokkiter Date: Thu, 16 Nov 2023 18:12:58 +0800 Subject: [PATCH] fix ticker leak Signed-off-by: rokkiter --- cmd/containerd-stress/cri_worker.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cmd/containerd-stress/cri_worker.go b/cmd/containerd-stress/cri_worker.go index 72f358f58..a206f0534 100644 --- a/cmd/containerd-stress/cri_worker.go +++ b/cmd/containerd-stress/cri_worker.go @@ -117,23 +117,19 @@ func (w *criWorker) runSandbox(tctx, ctx context.Context, id string) (err error) // verify it is running ? ticker := time.NewTicker(250 * time.Millisecond) - quit := make(chan struct{}) go func() { for { select { case <-tctx.Done(): - close(quit) + ticker.Stop() return case <-ticker.C: // do stuff status, err := w.client.PodSandboxStatus(sb) if err != nil && status.GetState() == runtime.PodSandboxState_SANDBOX_READY { - close(quit) + ticker.Stop() return } - case <-quit: - ticker.Stop() - return } } }()