Switch to golangci-lint

Signed-off-by: Maksym Pavlenko <makpav@amazon.com>

.golangci.yml

@@ -0,0 +1,21 @@
+linters:
+  enable:
+    - structcheck
+    - varcheck
+    - staticcheck
+    - unconvert
+    - gofmt
+    - goimports
+    - golint
+    - ineffassign
+    - vet
+    - unused
+    - misspell
+  disable:
+    - errcheck
+
+run:
+  skip-dirs:
+    - api
+    - design
+    - docs

.gometalinter.json

@@ -1,23 +0,0 @@
-{
-  "Vendor": true,
-  "Deadline": "2m",
-  "Sort": ["linter", "severity", "path", "line"],
-  "Exclude": [
-    ".*\\.pb\\.go",
-    "fetch\\.go:.*::error: unrecognized printf verb 'r'"
-  ],
-  "EnableGC": true,
-
-  "Enable": [
-    "structcheck",
-    "varcheck",
-    "staticcheck",
-    "unconvert",
-
-    "gofmt",
-    "goimports",
-    "golint",
-    "ineffassign",
-    "vet"
-  ]
-}

Makefile

@@ -121,7 +121,7 @@ all: binaries
 
 check: proto-fmt ## run all linters
 	@echo "$(WHALE) $@"
-	gometalinter --config .gometalinter.json ./...
+	golangci-lint run
 
 ci: check binaries checkprotos coverage coverage-integration ## to be used by the CI
 

script/setup/install-dev-tools

@@ -21,6 +21,5 @@
 set -eu -o pipefail
 
 go get -u github.com/stevvooe/protobuild
-go get -u github.com/alecthomas/gometalinter
+go get -u github.com/golangci/golangci-lint/cmd/golangci-lint
-gometalinter --install >/dev/null
 go get -u github.com/cpuguy83/go-md2man