github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

use happy-eyeballs for port-forwarding

Browse Source 
golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs)
by default in 1.12.
It means that if a host resolves to both IPv6 and IPv4,
it will try to connect to any of those addresses and use the
working connection.
However, the implementation uses go routines to start both connections in parallel,
and this has limitations when running inside a namespace, so we try to the connections
serially, trying IPv4 first for keeping the same behaviour.
xref https://github.com/golang/go/issues/44922

Signed-off-by: Antonio Ojea <aojea@redhat.com>
This commit is contained in:
Antonio Ojea 2021-03-09 11:02:38 +01:00 committed by Antonio Ojea
parent a5d17eb507
commit 305b425830
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/cri/server/sandbox_portforward_linux.go
View File

@ -62,12 +62,24 @@ func (c *criService) portForward(ctx context.Context, id string, port int32, str
log.G(ctx).Infof("Executing port forwarding in network namespace %q", netNSPath) log.G(ctx).Infof("Executing port forwarding in network namespace %q", netNSPath)
err = netNSDo(func(_ ns.NetNS) error { err = netNSDo(func(_ ns.NetNS) error {
defer stream.Close() defer stream.Close()
// TODO: hardcoded to tcp4 because localhost resolves to ::1 by default if the system has IPv6 enabled. // localhost can resolve to both IPv4 and IPv6 addresses in dual-stack systems
// Theoretically happy eyeballs will try IPv6 first and fallback to IPv4 // but the application can be listening in one of the IP families only.
// but resolving localhost doesn't seem to return and IPv4 address, thus failing the connection. // golang has enabled RFC 6555 Fast Fallback (aka HappyEyeballs) by default in 1.12
// It means that if a host resolves to both IPv6 and IPv4, it will try to connect to any
// of those addresses and use the working connection.
// However, the implementation uses go routines to start both connections in parallel,
// and this cases that the connection is done outside the namespace, so we try to connect
// serially.
// We try IPv4 first to keep current behavior and we fallback to IPv6 if the connection fails.
// xref https://github.com/golang/go/issues/44922
var conn net.Conn
conn, err := net.Dial("tcp4", fmt.Sprintf("localhost:%d", port)) conn, err := net.Dial("tcp4", fmt.Sprintf("localhost:%d", port))
if err != nil { if err != nil {
return errors.Wrapf(err, "failed to dial %d", port) var errV6 error
conn, errV6 = net.Dial("tcp6", fmt.Sprintf("localhost:%d", port))
if errV6 != nil {
return fmt.Errorf("failed to connect to localhost:%d inside namespace %q, IPv4: %v IPv6 %v ", port, id, err, errV6)
}
} }
defer conn.Close() defer conn.Close()