From 32ba75f0fbfe47ad94e7c7daccc9f31efd0b2db2 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 28 Jan 2020 18:35:49 +0100 Subject: [PATCH] Update Golang 1.13.7 (CVE-2020-0601, CVE-2020-7919) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit full diff: https://github.com/golang/go/compare/go1.13.6...go1.13.7 go1.13.7 (released 2020/01/28) includes two security fixes. One mitigates the CVE-2020-0601 certificate verification bypass on Windows. The other affects only 32-bit architectures. https://github.com/golang/go/issues?q=milestone%3AGo1.13.7+label%3ACherryPickApproved - X.509 certificate validation bypass on Windows 10 A Windows vulnerability allows attackers to spoof valid certificate chains when the system root store is in use. These releases include a mitigation for Go applications, but it’s strongly recommended that affected users install the Windows security update to protect their system. This issue is CVE-2020-0601 and Go issue golang.org/issue/36834. - Panic in crypto/x509 certificate parsing and golang.org/x/crypto/cryptobyte On 32-bit architectures, a malformed input to crypto/x509 or the ASN.1 parsing functions of golang.org/x/crypto/cryptobyte can lead to a panic. The malformed certificate can be delivered via a crypto/tls connection to a client, or to a server that accepts client certificates. net/http clients can be made to crash by an HTTPS server, while net/http servers that accept client certificates will recover the panic and are unaffected. Thanks to Project Wycheproof for providing the test cases that led to the discovery of this issue. The issue is CVE-2020-7919 and Go issue golang.org/issue/36837. This is also fixed in version v0.0.0-20200124225646-8b5121be2f68 of golang.org/x/crypto/cryptobyte. Signed-off-by: Sebastiaan van Stijn --- .appveyor.yml | 2 +- .github/workflows/nightly.yml | 4 ++-- .travis.yml | 2 +- contrib/Dockerfile.test | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.appveyor.yml b/.appveyor.yml index c55d5a04e..9a019c6b4 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -13,7 +13,7 @@ environment: GOPATH: C:\gopath CGO_ENABLED: 0 matrix: - - GO_VERSION: 1.13.6 + - GO_VERSION: 1.13.7 before_build: - choco install -y mingw --version 5.3.0 diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index d9c609087..4bdfa7857 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -12,7 +12,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v1 with: - go-version: '1.13.6' + go-version: '1.13.7' - name: Checkout uses: actions/checkout@v1 @@ -123,7 +123,7 @@ jobs: - name: Set up Go uses: actions/setup-go@v1 with: - go-version: '1.13.6' + go-version: '1.13.7' - name: Checkout uses: actions/checkout@v1 diff --git a/.travis.yml b/.travis.yml index 345fcbf91..b08662b63 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,7 +10,7 @@ os: - linux go: - - "1.13.6" + - "1.13.7" env: - TRAVIS_GOOS=linux TEST_RUNTIME=io.containerd.runc.v1 TRAVIS_CGO_ENABLED=1 TRAVIS_DISTRO=bionic GOPROXY=direct diff --git a/contrib/Dockerfile.test b/contrib/Dockerfile.test index 6ba823ca5..187e8e71d 100644 --- a/contrib/Dockerfile.test +++ b/contrib/Dockerfile.test @@ -6,7 +6,7 @@ # 3.) $ make binaries install test # -ARG GOLANG_VERSION=1.13.6 +ARG GOLANG_VERSION=1.13.7 FROM golang:${GOLANG_VERSION} AS golang-base RUN mkdir -p /go/src/github.com/containerd/containerd