From 181d7d507655109d58fa9d994539d48833f4d67a Mon Sep 17 00:00:00 2001 From: Lantao Liu Date: Fri, 1 Dec 2017 19:17:44 +0000 Subject: [PATCH] Move shim cgroup opts to pkg/containerd/opts. Signed-off-by: Lantao Liu --- pkg/{ => containerd}/opts/task.go | 13 +++++++++++++ pkg/server/container_start.go | 4 ++-- pkg/server/sandbox_run.go | 3 +-- 3 files changed, 16 insertions(+), 4 deletions(-) rename pkg/{ => containerd}/opts/task.go (50%) diff --git a/pkg/opts/task.go b/pkg/containerd/opts/task.go similarity index 50% rename from pkg/opts/task.go rename to pkg/containerd/opts/task.go index 37113ee38..6766263c2 100644 --- a/pkg/opts/task.go +++ b/pkg/containerd/opts/task.go @@ -1,3 +1,16 @@ +/* +Copyright 2017 The Kubernetes Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + package opts import ( diff --git a/pkg/server/container_start.go b/pkg/server/container_start.go index 21d3edbc5..b362aa430 100644 --- a/pkg/server/container_start.go +++ b/pkg/server/container_start.go @@ -27,7 +27,7 @@ import ( "golang.org/x/net/context" "k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime" - criopts "github.com/kubernetes-incubator/cri-containerd/pkg/opts" + customopts "github.com/kubernetes-incubator/cri-containerd/pkg/containerd/opts" cio "github.com/kubernetes-incubator/cri-containerd/pkg/server/io" containerstore "github.com/kubernetes-incubator/cri-containerd/pkg/store/container" ) @@ -129,7 +129,7 @@ func (c *criContainerdService) startContainer(ctx context.Context, var taskOpts []containerd.NewTaskOpts if cgroup := sandbox.Config.GetLinux().GetCgroupParent(); cgroup != "" { - taskOpts = append(taskOpts, criopts.WithContainerdShimCgroup(cgroup)) + taskOpts = append(taskOpts, customopts.WithContainerdShimCgroup(cgroup)) } task, err := container.NewTask(ctx, ioCreation, taskOpts...) if err != nil { diff --git a/pkg/server/sandbox_run.go b/pkg/server/sandbox_run.go index 7eec0c0c1..9675f1346 100644 --- a/pkg/server/sandbox_run.go +++ b/pkg/server/sandbox_run.go @@ -36,7 +36,6 @@ import ( "k8s.io/kubernetes/pkg/kubelet/apis/cri/v1alpha1/runtime" customopts "github.com/kubernetes-incubator/cri-containerd/pkg/containerd/opts" - criopts "github.com/kubernetes-incubator/cri-containerd/pkg/opts" sandboxstore "github.com/kubernetes-incubator/cri-containerd/pkg/store/sandbox" "github.com/kubernetes-incubator/cri-containerd/pkg/util" ) @@ -208,7 +207,7 @@ func (c *criContainerdService) RunPodSandbox(ctx context.Context, r *runtime.Run // We don't need stdio for sandbox container. var taskOpts []containerd.NewTaskOpts if cgroup := config.GetLinux().GetCgroupParent(); cgroup != "" { - taskOpts = append(taskOpts, criopts.WithContainerdShimCgroup(cgroup)) + taskOpts = append(taskOpts, customopts.WithContainerdShimCgroup(cgroup)) } task, err := container.NewTask(ctx, containerdio.NullIO, taskOpts...) if err != nil {