Merge pull request #4367 from gaurav1086/TestExchangeFilters_fix_deadlock

[events/exchange_test] Fix deadlock in TestExchangeFilters
This commit is contained in:
Phil Estes 2020-07-10 15:12:15 -04:00 committed by GitHub
commit 3f427d3d63
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -19,7 +19,6 @@ package exchange
import (
"context"
"reflect"
"sync"
"testing"
"time"
@ -221,11 +220,8 @@ func TestExchangeFilters(t *testing.T) {
}
t.Log("publish")
var wg sync.WaitGroup
wg.Add(1)
errChan := make(chan error)
go func() {
defer wg.Done()
defer close(errChan)
for _, es := range testEventSets {
for _, e := range es.events {
@ -240,7 +236,6 @@ func TestExchangeFilters(t *testing.T) {
}()
t.Log("waiting")
wg.Wait()
if err := <-errChan; err != nil {
t.Fatal(err)
}