Merge pull request #18 from mikebrow/enable-unit-test

Enables unit tests for Travis build; address nits in Makefile; increase lint timeout to 5min

.travis.yml

@@ -17,3 +17,4 @@ script:
     - make .gitvalidation
     - make verify
     - make binaries
+    - make test

Makefile

@@ -17,7 +17,9 @@ EPOCH_TEST_COMMIT ?= f9e02affccd51702191e5312665a16045ffef8ab
 PROJECT := github.com/kubernetes-incubator/cri-containerd
 BINDIR ?= ${DESTDIR}/usr/local/bin
 BUILD_DIR ?= _output
-# VERSION is the version of the binary.
+# VERSION is derived from the current tag for HEAD plus amends. Version is used
+# to set/overide the criContainerdVersion variable in the verison package for
+# cri-containerd.
 VERSION:=$(shell git describe --tags --dirty)
 BUILD_TAGS:= -ldflags '-X $(PROJECT)/pkg/version.criContainerdVersion=$(VERSION)'
 
@@ -81,7 +83,8 @@ uninstall:
 	rm -f $(BINDIR)/cri-containerd
 
 .PHONY: .gitvalidation
-# When this is running in travis, it will only check the travis commit range
+# When this is running in travis, it will only check the travis commit range.
+# When running outside travis, it will check from $(EPOCH_TEST_COMMIT)..HEAD.
 .gitvalidation: check-gopath
 ifeq ($(TRAVIS),true)
 	git-validation -q -run DCO,short-subject
@@ -103,12 +106,12 @@ install.tools: .install.gitvalidation .install.gometalinter
 .PHONY: \
 	binaries \
 	boiler \
-	test \
 	clean \
 	default \
 	gofmt \
 	help \
 	install \
 	lint \
+	test \
 	uninstall \
 	version

hack/lint.sh

@@ -29,5 +29,5 @@ for d in $(find . -type d -a \( -iwholename './pkg*' -o -iwholename './cmd*' \))
 		 --cyclo-over=60 \
 		 --dupl-threshold=100 \
 		 --tests \
-		 --deadline=30s "${d}"
+		 --deadline=300s "${d}"
 done