Delete rootfs when container is deleted

Signed-off-by: Derek McGowan <derek@mcgstyle.net>

cmd/ctr/delete.go

@@ -17,13 +17,26 @@ var deleteCommand = cli.Command{
 		if err != nil {
 			return err
 		}
+		snapshotter, err := getSnapshotter(context)
+		if err != nil {
+			return err
+		}
 		id := context.Args().First()
 		if id == "" {
 			return errors.New("container id must be provided")
 		}
-		_, err = containers.Delete(gocontext.Background(), &execution.DeleteRequest{
+		ctx := gocontext.TODO()
+		_, err = containers.Delete(ctx, &execution.DeleteRequest{
 			ID: id,
 		})
-		return err
+		if err != nil {
+			return errors.Wrap(err, "failed to delete container")
+		}
+
+		if err := snapshotter.Remove(ctx, id); err != nil {
+			return errors.Wrapf(err, "failed to remove snapshot %q", id)
+		}
+
+		return nil
 	},
 }

cmd/ctr/run.go

@@ -127,6 +127,14 @@ var runCommand = cli.Command{
 				if err != nil {
 					return err
 				}
+			} else {
+				defer func() {
+					if id != "" {
+						if err := snapshotter.Remove(ctx, id); err != nil {
+							logrus.WithError(err).Errorf("failed to remove snapshot %q", id)
+						}
+					}
+				}()
 			}
 
 			ic, err := image.Config(ctx, content)
@@ -206,6 +214,9 @@ var runCommand = cli.Command{
 			}); err != nil {
 				return err
 			}
+		} else {
+			// Don't remove snapshot
+			id = ""
 		}
 		if status != 0 {
 			return cli.NewExitError("", int(status))