From 4674ad7beb2cc704a2ec0eb88aa4091382efbc8b Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Wed, 24 Mar 2021 22:40:22 -0700 Subject: [PATCH] Ignore some tests on darwin Signed-off-by: Maksym Pavlenko --- archive/tar_test.go | 2 +- pkg/cri/server/container_create_test.go | 9 +++++++++ pkg/cri/server/sandbox_run_test.go | 5 +++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/archive/tar_test.go b/archive/tar_test.go index 568f5a95f..adcc2eb97 100644 --- a/archive/tar_test.go +++ b/archive/tar_test.go @@ -1,4 +1,4 @@ -// +build !windows +// +build !windows,!darwin /* Copyright The containerd Authors. diff --git a/pkg/cri/server/container_create_test.go b/pkg/cri/server/container_create_test.go index a5954c510..8f3a39c88 100644 --- a/pkg/cri/server/container_create_test.go +++ b/pkg/cri/server/container_create_test.go @@ -19,6 +19,7 @@ package server import ( "context" "path/filepath" + goruntime "runtime" "testing" "github.com/containerd/containerd/oci" @@ -68,6 +69,10 @@ func TestGeneralContainerSpec(t *testing.T) { } func TestPodAnnotationPassthroughContainerSpec(t *testing.T) { + if goruntime.GOOS == "darwin" { + t.Skip("not implemented on Darwin") + } + testID := "test-id" testSandboxID := "sandbox-id" testContainerName := "container-name" @@ -272,6 +277,10 @@ func TestVolumeMounts(t *testing.T) { } func TestContainerAnnotationPassthroughContainerSpec(t *testing.T) { + if goruntime.GOOS == "darwin" { + t.Skip("not implemented on Darwin") + } + testID := "test-id" testSandboxID := "sandbox-id" testContainerName := "container-name" diff --git a/pkg/cri/server/sandbox_run_test.go b/pkg/cri/server/sandbox_run_test.go index d47af13f3..75960b36a 100644 --- a/pkg/cri/server/sandbox_run_test.go +++ b/pkg/cri/server/sandbox_run_test.go @@ -18,6 +18,7 @@ package server import ( "net" + goruntime "runtime" "testing" cni "github.com/containerd/go-cni" @@ -33,6 +34,10 @@ import ( ) func TestSandboxContainerSpec(t *testing.T) { + if goruntime.GOOS == "darwin" { + t.Skip("not implemented on Darwin") + } + testID := "test-id" nsPath := "test-cni" for desc, test := range map[string]struct {