github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

plugin: allow declaring a plugin depends on all others

Browse Source 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2017-10-09 20:43:51 -07:00
parent 8508e8252b
commit 49814646cf
No known key found for this signature in database
GPG Key ID: 67B3DED84EDC823F
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
plugin/plugin.go
View File

@ -18,6 +18,10 @@ var (
// this allows the plugin loader differentiate between a plugin which is configured // this allows the plugin loader differentiate between a plugin which is configured
// not to load and one that fails to load. // not to load and one that fails to load.
ErrSkipPlugin = errors.New("skip plugin") ErrSkipPlugin = errors.New("skip plugin")
// ErrInvalidRequires will be thrown if the requirements for a plugin are
// defined in an invalid manner.
ErrInvalidRequires = errors.New("invalid requires")
) )
// IsSkipPlugin returns true if the error is skipping the plugin // IsSkipPlugin returns true if the error is skipping the plugin
@ -34,6 +38,8 @@ type Type string
func (t Type) String() string { return string(t) } func (t Type) String() string { return string(t) }
const ( const (
// AllPlugins declares that the plugin should be initialized after all others.
AllPlugins Type = "*"
// RuntimePlugin implements a runtime // RuntimePlugin implements a runtime
RuntimePlugin Type = "io.containerd.runtime.v1" RuntimePlugin Type = "io.containerd.runtime.v1"
// GRPCPlugin implements a grpc service // GRPCPlugin implements a grpc service
@ -113,6 +119,17 @@ func Register(r *Registration) {
if r.ID == "" { if r.ID == "" {
panic(ErrNoPluginID) panic(ErrNoPluginID)
} }
var last bool
for _, requires := range r.Requires {
if requires == "*" {
last = true
}
}
if last && len(r.Requires) != 1 {
panic(ErrInvalidRequires)
}
register.r = append(register.r, r) register.r = append(register.r, r)
} }
@ -123,7 +140,8 @@ func Graph() (ordered []*Registration) {
added := map[*Registration]bool{} added := map[*Registration]bool{}
for _, r := range register.r { for _, r := range register.r {
children(r.Requires, added, &ordered)
children(r.ID, r.Requires, added, &ordered)
if !added[r] { if !added[r] {
ordered = append(ordered, r) ordered = append(ordered, r)
added[r] = true added[r] = true
@ -132,11 +150,11 @@ func Graph() (ordered []*Registration) {
return ordered return ordered
} }
func children(types []Type, added map[*Registration]bool, ordered *[]*Registration) { func children(id string, types []Type, added map[*Registration]bool, ordered *[]*Registration) {
for _, t := range types { for _, t := range types {
for _, r := range register.r { for _, r := range register.r {
if r.Type == t { if r.ID != id && (t == "*" || r.Type == t) {
children(r.Requires, added, ordered) children(r.ID, r.Requires, added, ordered)
if !added[r] { if !added[r] {
*ordered = append(*ordered, r) *ordered = append(*ordered, r)
added[r] = true added[r] = true