Improve install scripts

* Only use bash where needed (scripts with pipes that use -o pipefail)
* Make string comparisons POSIX compatible
* Handle whitespace(s) in GOPATH
* Remove superfluous quotes in variable assignments

Change-Id: If1ea55f06f402ded646b5085d4837c0996f90fab
Signed-off-by: Joakim Roubert <joakimr@axis.com>
This commit is contained in:
Joakim Roubert
2019-12-12 13:25:25 +01:00
parent 55698e6942
commit 499fbb0337
6 changed files with 19 additions and 19 deletions

View File

@@ -1,4 +1,4 @@
#!/usr/bin/env bash
#!/usr/bin/env sh
# Copyright The containerd Authors.
@@ -18,12 +18,12 @@
# Builds and installs critools including critest and crictl
# to /usr/local/bin.
#
set -eu -o pipefail
set -eu
go get -u github.com/onsi/ginkgo/ginkgo
CRITEST_COMMIT=v1.16.1
go get -d github.com/kubernetes-incubator/cri-tools/...
cd $GOPATH/src/github.com/kubernetes-incubator/cri-tools
cd "$GOPATH"/src/github.com/kubernetes-incubator/cri-tools
git checkout $CRITEST_COMMIT
make
make install