diff --git a/client.go b/client.go index 3cf7ff3ee..73d740379 100644 --- a/client.go +++ b/client.go @@ -87,7 +87,6 @@ func New(address string, opts ...ClientOpt) (*Client, error) { gopts := []grpc.DialOption{ grpc.WithBlock(), grpc.WithInsecure(), - grpc.WithTimeout(60 * time.Second), grpc.FailOnNonTempDialError(true), grpc.WithBackoffMaxDelay(3 * time.Second), grpc.WithDialer(dialer.Dialer), @@ -107,7 +106,9 @@ func New(address string, opts ...ClientOpt) (*Client, error) { ) } connector := func() (*grpc.ClientConn, error) { - conn, err := grpc.Dial(dialer.DialAddress(address), gopts...) + ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second) + defer cancel() + conn, err := grpc.DialContext(ctx, dialer.DialAddress(address), gopts...) if err != nil { return nil, errors.Wrapf(err, "failed to dial %q", address) } diff --git a/client_test.go b/client_test.go index 842b1a475..e1a1dd54c 100644 --- a/client_test.go +++ b/client_test.go @@ -21,15 +21,11 @@ import ( "context" "flag" "fmt" - "io/ioutil" - golog "log" "os" "os/exec" "testing" "time" - "google.golang.org/grpc/grpclog" - "github.com/containerd/containerd/images" "github.com/containerd/containerd/log" "github.com/containerd/containerd/namespaces" @@ -50,9 +46,6 @@ var ( ) func init() { - // Discard grpc logs so that they don't mess with our stdio - grpclog.SetLogger(golog.New(ioutil.Discard, "", golog.LstdFlags)) - flag.StringVar(&address, "address", defaultAddress, "The address to the containerd socket for use in the tests") flag.BoolVar(&noDaemon, "no-daemon", false, "Do not start a dedicated daemon for the tests") flag.BoolVar(&noCriu, "no-criu", false, "Do not run the checkpoint tests") diff --git a/cmd/containerd/command/main.go b/cmd/containerd/command/main.go index 8fba0fa38..a37240b63 100644 --- a/cmd/containerd/command/main.go +++ b/cmd/containerd/command/main.go @@ -20,7 +20,6 @@ import ( gocontext "context" "fmt" "io/ioutil" - golog "log" "net" "os" "os/signal" @@ -50,7 +49,7 @@ high performance container runtime func init() { // Discard grpc logs so that they don't mess with our stdio - grpclog.SetLogger(golog.New(ioutil.Discard, "", golog.LstdFlags)) + grpclog.SetLoggerV2(grpclog.NewLoggerV2(ioutil.Discard, ioutil.Discard, ioutil.Discard)) cli.VersionPrinter = func(c *cli.Context) { fmt.Println(c.App.Name, version.Package, c.App.Version, version.Revision) diff --git a/cmd/containerd/command/publish.go b/cmd/containerd/command/publish.go index d297732bf..f0983bc24 100644 --- a/cmd/containerd/command/publish.go +++ b/cmd/containerd/command/publish.go @@ -95,12 +95,13 @@ func connect(address string, d func(string, time.Duration) (net.Conn, error)) (* gopts := []grpc.DialOption{ grpc.WithBlock(), grpc.WithInsecure(), - grpc.WithTimeout(60 * time.Second), grpc.WithDialer(d), grpc.FailOnNonTempDialError(true), grpc.WithBackoffMaxDelay(3 * time.Second), } - conn, err := grpc.Dial(dialer.DialAddress(address), gopts...) + ctx, cancel := gocontext.WithTimeout(gocontext.Background(), 60*time.Second) + defer cancel() + conn, err := grpc.DialContext(ctx, dialer.DialAddress(address), gopts...) if err != nil { return nil, errors.Wrapf(err, "failed to dial %q", address) } diff --git a/cmd/ctr/app/main.go b/cmd/ctr/app/main.go index 0cc3a22c6..ac91d038c 100644 --- a/cmd/ctr/app/main.go +++ b/cmd/ctr/app/main.go @@ -19,7 +19,6 @@ package app import ( "fmt" "io/ioutil" - "log" "github.com/containerd/containerd/cmd/ctr/commands/containers" "github.com/containerd/containerd/cmd/ctr/commands/content" @@ -44,7 +43,7 @@ var extraCmds = []cli.Command{} func init() { // Discard grpc logs so that they don't mess with our stdio - grpclog.SetLogger(log.New(ioutil.Discard, "", log.LstdFlags)) + grpclog.SetLoggerV2(grpclog.NewLoggerV2(ioutil.Discard, ioutil.Discard, ioutil.Discard)) cli.VersionPrinter = func(c *cli.Context) { fmt.Println(c.App.Name, version.Package, c.App.Version)