From 587ee80f61de6ea368cfe1eaa02f67e85d0fa3f7 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 14 Jun 2024 12:12:22 +0200 Subject: [PATCH] pkg/tracing: LogrusHook.Fire: micro-optimisation Check span.IsRecording first, as it's a more lightweight check than span.SpanContext().IsValid() Signed-off-by: Sebastiaan van Stijn --- pkg/tracing/log.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/tracing/log.go b/pkg/tracing/log.go index f2604cd60..3af24a294 100644 --- a/pkg/tracing/log.go +++ b/pkg/tracing/log.go @@ -59,7 +59,7 @@ func (h *LogrusHook) Fire(entry *log.Entry) error { return nil } - if !span.SpanContext().IsValid() || !span.IsRecording() { + if !span.IsRecording() || !span.SpanContext().IsValid() { return nil }