From 591d7e2fb1af895e2326f1ac96c316bf0a6296e3 Mon Sep 17 00:00:00 2001 From: Michael Crosby Date: Tue, 26 Jan 2021 14:57:54 -0500 Subject: [PATCH] remove exec sync debug contents from logs This was dumping untrusted output to the debug logs from user containers. We should not dump this type of information to reduce log sizes and any information leaks from user containers. Signed-off-by: Michael Crosby --- pkg/cri/server/instrumented_service.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/pkg/cri/server/instrumented_service.go b/pkg/cri/server/instrumented_service.go index 21f254cd5..893de98cd 100644 --- a/pkg/cri/server/instrumented_service.go +++ b/pkg/cri/server/instrumented_service.go @@ -253,8 +253,6 @@ func (in *instrumentedService) ExecSync(ctx context.Context, r *runtime.ExecSync log.G(ctx).WithError(err).Errorf("ExecSync for %q failed", r.GetContainerId()) } else { log.G(ctx).Debugf("ExecSync for %q returns with exit code %d", r.GetContainerId(), res.GetExitCode()) - log.G(ctx).Debugf("ExecSync for %q outputs - stdout: %q, stderr: %q", r.GetContainerId(), - res.GetStdout(), res.GetStderr()) } }() res, err = in.c.ExecSync(ctrdutil.WithNamespace(ctx), r)