github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #1941 from crosbymichael/reviewers

Browse Source 
Add concept of reviews and 2 new reviewers
This commit is contained in:
Daniel, Dao Quang Minh 2018-01-04 11:53:56 +00:00 committed by GitHub
commit 5b931ca703
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
MAINTAINERS
View File

@ -28,6 +28,19 @@ It's easy to appreciate a really cool and technically advanced feature. It's har
to appreciate the absence of bugs, the slow but steady improvement in stability, to appreciate the absence of bugs, the slow but steady improvement in stability,
or the reliability of a release process. But those things distinguish a good or the reliability of a release process. But those things distinguish a good
project from a great one. project from a great one.
"""
[Rules.reviewer]
title = "What is a reviewer?"
text = """
A reviewer is a core role within the project.
They share in reviewing issues and pull requests and their LGTM count towards the
required LGTM count to merge a code change into the project.
Reviewers are part of the organization but do not have write access.
Becoming a reviewer is a core aspect in the journey to becoming a maintainer.
""" """
[Rules.adding-maintainers] [Rules.adding-maintainers]
@ -202,6 +215,11 @@ containerd defers to the [Technical Steering Committee](https://github.com/moby/
"mlaventure", "mlaventure",
"stevvooe", "stevvooe",
] ]
[Org.Reviewers]
people = [
"dnephin",
"jessvalarezo",
]
[People] [People]
@ -249,3 +267,13 @@ containerd defers to the [Technical Steering Committee](https://github.com/moby/
Name = "Stephen Day" Name = "Stephen Day"
Email = "stephen.day@docker.com" Email = "stephen.day@docker.com"
GitHub = "stevvooe" GitHub = "stevvooe"
[People.jessvalarezo]
Name = "Jessica Valarezo"
Email = "valarezo.jessica@gmail.com"
GitHub = "jessvalarezo"
[People.dnephin]
Name = "Daniel Nephin"
Email = "dnephin@gmail.com"
GitHub = "dnephin"