Merge pull request #1941 from crosbymichael/reviewers
Add concept of reviews and 2 new reviewers
This commit is contained in:
		
							
								
								
									
										28
									
								
								MAINTAINERS
									
									
									
									
									
								
							
							
						
						
									
										28
									
								
								MAINTAINERS
									
									
									
									
									
								
							| @@ -28,6 +28,19 @@ It's easy to appreciate a really cool and technically advanced feature. It's har | |||||||
| to appreciate the absence of bugs, the slow but steady improvement in stability, | to appreciate the absence of bugs, the slow but steady improvement in stability, | ||||||
| or the reliability of a release process. But those things distinguish a good | or the reliability of a release process. But those things distinguish a good | ||||||
| project from a great one. | project from a great one. | ||||||
|  | """ | ||||||
|  |  | ||||||
|  | 	[Rules.reviewer] | ||||||
|  |  | ||||||
|  | 	title = "What is a reviewer?" | ||||||
|  |  | ||||||
|  | 	text = """ | ||||||
|  | A reviewer is a core role within the project. | ||||||
|  | They share in reviewing issues and pull requests and their LGTM count towards the | ||||||
|  | required LGTM count to merge a code change into the project. | ||||||
|  |  | ||||||
|  | Reviewers are part of the organization but do not have write access. | ||||||
|  | Becoming a reviewer is a core aspect in the journey to becoming a maintainer. | ||||||
| """ | """ | ||||||
|  |  | ||||||
| 	[Rules.adding-maintainers] | 	[Rules.adding-maintainers] | ||||||
| @@ -202,6 +215,11 @@ containerd defers to the [Technical Steering Committee](https://github.com/moby/ | |||||||
| 			"mlaventure", | 			"mlaventure", | ||||||
| 			"stevvooe", | 			"stevvooe", | ||||||
| 		] | 		] | ||||||
|  | 	[Org.Reviewers] | ||||||
|  | 		people = [ | ||||||
|  | 			"dnephin", | ||||||
|  | 			"jessvalarezo", | ||||||
|  | 		] | ||||||
|  |  | ||||||
| [People] | [People] | ||||||
|  |  | ||||||
| @@ -249,3 +267,13 @@ containerd defers to the [Technical Steering Committee](https://github.com/moby/ | |||||||
| 	Name = "Stephen Day" | 	Name = "Stephen Day" | ||||||
| 	Email = "stephen.day@docker.com" | 	Email = "stephen.day@docker.com" | ||||||
| 	GitHub = "stevvooe" | 	GitHub = "stevvooe" | ||||||
|  |  | ||||||
|  | 	[People.jessvalarezo] | ||||||
|  | 	Name = "Jessica Valarezo" | ||||||
|  | 	Email = "valarezo.jessica@gmail.com" | ||||||
|  | 	GitHub = "jessvalarezo" | ||||||
|  |  | ||||||
|  | 	[People.dnephin] | ||||||
|  | 	Name = "Daniel Nephin" | ||||||
|  | 	Email = "dnephin@gmail.com" | ||||||
|  | 	GitHub = "dnephin" | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Daniel, Dao Quang Minh
					Daniel, Dao Quang Minh