github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #8203 from dcantah/sandbox-errors

Browse Source 
Sandbox: Fix/enhance error messages for Create
This commit is contained in:
Fu Wei 2023-03-04 23:07:20 +08:00 committed by GitHub
commit 5da7e2c097
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/sandbox/controller.go
View File

@ -102,9 +102,8 @@ func (c *controllerLocal) Create(ctx context.Context, sandboxID string, opts ...
Runtime: info.Runtime.Name, Runtime: info.Runtime.Name,
TaskOptions: nil, TaskOptions: nil,
}) })
if err != nil { if err != nil {
return fmt.Errorf("failed to start new sandbox: %w", err) return fmt.Errorf("failed to start new shim for sandbox %s: %w", sandboxID, err)
} }
svc, err := sandbox.NewClient(shim.Client()) svc, err := sandbox.NewClient(shim.Client())
@ -127,7 +126,7 @@ func (c *controllerLocal) Create(ctx context.Context, sandboxID string, opts ...
Options: options, Options: options,
}); err != nil { }); err != nil {
// TODO: Delete sandbox shim here. // TODO: Delete sandbox shim here.
return fmt.Errorf("failed to start sandbox %s: %w", sandboxID, errdefs.FromGRPC(err)) return fmt.Errorf("failed to create sandbox %s: %w", sandboxID, errdefs.FromGRPC(err))
} }
return nil return nil