cio: should not open fifo for stderr if terminal

fix: #4342 Signed-off-by: Wei Fu <fuweid89@gmail.com>
2020-07-01 23:21:36 +08:00
parent 468d4e1ccf
commit 68b736ddfc
3 changed files with 55 additions and 5 deletions
--- a/cio/io_unix.go
+++ b/cio/io_unix.go
@@ -132,7 +132,7 @@ func openFifos(ctx context.Context, fifos *FIFOSet) (pipes, error) {
 			}
 		}()
 	}
-	if fifos.Stderr != "" {
+	if !fifos.Terminal && fifos.Stderr != "" {
 		if f.Stderr, err = fifo.OpenFifo(ctx, fifos.Stderr, syscall.O_RDONLY|syscall.O_CREAT|syscall.O_NONBLOCK, 0700); err != nil {
 			return f, errors.Wrapf(err, "failed to open stderr fifo")
 		}