github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Do not use go get to install executables

Browse Source 
https://go.dev/doc/go-get-install-deprecation

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This commit is contained in:
Kazuyoshi Kato 2021-12-03 14:22:04 -08:00
parent d06bce4d3d
commit 6b0e2414c8
4 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/ci.yml vendored
View File

@ -88,7 +88,6 @@ jobs:
shell: bash shell: bash
run: | run: |
echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV
echo "GO111MODULE=off" >> $GITHUB_ENV
echo "${{ github.workspace }}/bin" >> $GITHUB_PATH echo "${{ github.workspace }}/bin" >> $GITHUB_PATH
- name: Install protobuf - name: Install protobuf
@ -113,7 +112,7 @@ jobs:
with: with:
go-version: '1.17.3' go-version: '1.17.3'
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- run: go get github.com/cpuguy83/go-md2man/v2@v2.0.1 - run: go install github.com/cpuguy83/go-md2man/v2@v2.0.1
- run: make man - run: make man
# Make sure binaries compile with other platforms # Make sure binaries compile with other platforms

2
script/setup/install-critools
View File

@ -23,7 +23,7 @@ set -eu -o pipefail
script_dir="$(cd -- "$(dirname -- "$0")" > /dev/null 2>&1; pwd -P)" script_dir="$(cd -- "$(dirname -- "$0")" > /dev/null 2>&1; pwd -P)"
cd "$(go env GOPATH)" cd "$(go env GOPATH)"
go get -u github.com/onsi/ginkgo/ginkgo go install github.com/onsi/ginkgo/ginkgo@v1.16.5
: "${CRITEST_COMMIT:=$(cat "${script_dir}/critools-version")}" : "${CRITEST_COMMIT:=$(cat "${script_dir}/critools-version")}"
: "${DESTDIR:=""}" : "${DESTDIR:=""}"

14
script/setup/install-dev-tools
View File

@ -20,18 +20,14 @@
# #
set -eu -o pipefail set -eu -o pipefail
# change to tmp dir, otherwise `go get` will change go.mod # install `protobuild` and other commands
cd "$GOPATH" go install github.com/stevvooe/protobuild@v0.1.0
go install github.com/cpuguy83/go-md2man/v2@v2.0.1
# install the `protobuild` binary in $GOPATH/bin; requires module-aware install go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.42.0
# to pin dependencies
GO111MODULE=on go get github.com/stevvooe/protobuild@v0.1.0
# the following packages need to exist in $GOPATH so we can't use # the following packages need to exist in $GOPATH so we can't use
# go modules-aware mode of `go get` for these includes used during # go modules-aware mode of `go get` for these includes used during
# proto building # proto building
cd "$GOPATH"
GO111MODULE=off go get -d github.com/gogo/googleapis || true GO111MODULE=off go get -d github.com/gogo/googleapis || true
GO111MODULE=off go get -d github.com/gogo/protobuf || true GO111MODULE=off go get -d github.com/gogo/protobuf || true
GO111MODULE=on go get github.com/cpuguy83/go-md2man/v2@v2.0.1
GO111MODULE=on go get github.com/golangci/golangci-lint/cmd/golangci-lint@v1.42.0

2
script/setup/prepare_env_windows.ps1
View File

@ -37,7 +37,7 @@ Write-Host $env:PATH
mkdir c:\Logs mkdir c:\Logs
# Pull junit conversion tool # Pull junit conversion tool
go get -u github.com/jstemmer/go-junit-report go install github.com/jstemmer/go-junit-report@v0.9.1
# Get critctl tool. Used for cri-integration tests # Get critctl tool. Used for cri-integration tests
$CRICTL_DOWNLOAD_URL="https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.21.0/crictl-v1.21.0-windows-amd64.tar.gz" $CRICTL_DOWNLOAD_URL="https://github.com/kubernetes-sigs/cri-tools/releases/download/v1.21.0/crictl-v1.21.0-windows-amd64.tar.gz"