From 710d22366de32fd959d25098a31d0bef9a12319e Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 23 Jun 2023 13:05:41 +0200 Subject: [PATCH] removes/docker: replace some fmt.Sprintfs with strconv Teeny-tiny optimizations: BenchmarkSprintf-10 37735996 32.31 ns/op 0 B/op 0 allocs/op BenchmarkItoa-10 591945836 2.031 ns/op 0 B/op 0 allocs/op BenchmarkFormatUint-10 593701444 2.014 ns/op 0 B/op 0 allocs/op Signed-off-by: Sebastiaan van Stijn --- remotes/docker/fetcher_fuzz.go | 3 ++- remotes/docker/fetcher_test.go | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/remotes/docker/fetcher_fuzz.go b/remotes/docker/fetcher_fuzz.go index b98886c59..849670a18 100644 --- a/remotes/docker/fetcher_fuzz.go +++ b/remotes/docker/fetcher_fuzz.go @@ -25,6 +25,7 @@ import ( "net/http" "net/http/httptest" "net/url" + "strconv" refDocker "github.com/containerd/containerd/reference/docker" ) @@ -37,7 +38,7 @@ func FuzzFetcher(data []byte) int { s := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) { rw.Header().Set("content-range", fmt.Sprintf("bytes %d-%d/%d", 0, dataLen-1, dataLen)) - rw.Header().Set("content-length", fmt.Sprintf("%d", dataLen)) + rw.Header().Set("content-length", strconv.Itoa(dataLen)) rw.Write(data) })) defer s.Close() diff --git a/remotes/docker/fetcher_test.go b/remotes/docker/fetcher_test.go index 07cc90a24..695d6045f 100644 --- a/remotes/docker/fetcher_test.go +++ b/remotes/docker/fetcher_test.go @@ -25,6 +25,7 @@ import ( "net/http" "net/http/httptest" "net/url" + "strconv" "testing" "github.com/stretchr/testify/assert" @@ -39,8 +40,8 @@ func TestFetcherOpen(t *testing.T) { if start > 0 { rw.Header().Set("content-range", fmt.Sprintf("bytes %d-127/128", start)) } - rw.Header().Set("content-length", fmt.Sprintf("%d", len(content[start:]))) - rw.Write(content[start:]) + rw.Header().Set("content-length", strconv.Itoa(len(content[start:]))) + _, _ = rw.Write(content[start:]) })) defer s.Close()