Retry client connection in waitForStart
Signed-off-by: Swagat Bora <sbora@amazon.com>
This commit is contained in:
parent
3bfa8556cf
commit
727b33c710
@ -1006,7 +1006,7 @@ func TestDaemonRestartWithRunningShim(t *testing.T) {
|
|||||||
t.Errorf(`first task.Wait() should have failed with "transport is closing"`)
|
t.Errorf(`first task.Wait() should have failed with "transport is closing"`)
|
||||||
}
|
}
|
||||||
|
|
||||||
waitCtx, cancel := context.WithTimeout(ctx, 1*time.Second)
|
waitCtx, cancel := context.WithTimeout(ctx, 4*time.Second)
|
||||||
c, err := ctrd.waitForStart(waitCtx)
|
c, err := ctrd.waitForStart(waitCtx)
|
||||||
cancel()
|
cancel()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
@ -24,6 +24,7 @@ import (
|
|||||||
"runtime"
|
"runtime"
|
||||||
"sync"
|
"sync"
|
||||||
"syscall"
|
"syscall"
|
||||||
|
"time"
|
||||||
|
|
||||||
. "github.com/containerd/containerd"
|
. "github.com/containerd/containerd"
|
||||||
exec "golang.org/x/sys/execabs"
|
exec "golang.org/x/sys/execabs"
|
||||||
@ -59,21 +60,30 @@ func (d *daemon) waitForStart(ctx context.Context) (*Client, error) {
|
|||||||
client *Client
|
client *Client
|
||||||
serving bool
|
serving bool
|
||||||
err error
|
err error
|
||||||
|
ticker = time.NewTicker(500 * time.Millisecond)
|
||||||
)
|
)
|
||||||
|
defer ticker.Stop()
|
||||||
|
|
||||||
client, err = New(d.addr)
|
for {
|
||||||
if err != nil {
|
select {
|
||||||
return nil, err
|
case <-ticker.C:
|
||||||
}
|
client, err = New(d.addr)
|
||||||
serving, err = client.IsServing(ctx)
|
if err != nil {
|
||||||
if !serving {
|
continue
|
||||||
client.Close()
|
}
|
||||||
if err == nil {
|
serving, err = client.IsServing(ctx)
|
||||||
err = errors.New("connection was successful but service is not available")
|
if !serving {
|
||||||
|
client.Close()
|
||||||
|
if err == nil {
|
||||||
|
err = errors.New("connection was successful but service is not available")
|
||||||
|
}
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
return client, err
|
||||||
|
case <-ctx.Done():
|
||||||
|
return nil, fmt.Errorf("context deadline exceeded: %w", err)
|
||||||
}
|
}
|
||||||
return nil, err
|
|
||||||
}
|
}
|
||||||
return client, err
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (d *daemon) Stop() error {
|
func (d *daemon) Stop() error {
|
||||||
|
Loading…
Reference in New Issue
Block a user