diff --git a/pkg/reference/reference.go b/pkg/reference/reference.go index 23b88214e..0bbcdab29 100644 --- a/pkg/reference/reference.go +++ b/pkg/reference/reference.go @@ -157,9 +157,9 @@ func (r Spec) String() string { // Either may be empty and it is the callers job to validate them // appropriately. func SplitObject(obj string) (tag string, dgst digest.Digest) { - parts := strings.SplitAfterN(obj, "@", 2) - if len(parts) < 2 { - return parts[0], "" + if i := strings.Index(obj, "@"); i >= 0 { + // Offset by one so preserve the "@" in the tag returned. + return obj[:i+1], digest.Digest(obj[i+1:]) } - return parts[0], digest.Digest(parts[1]) + return obj, "" } diff --git a/pkg/reference/reference_test.go b/pkg/reference/reference_test.go index 91f479ba3..b8929a5c8 100644 --- a/pkg/reference/reference_test.go +++ b/pkg/reference/reference_test.go @@ -192,3 +192,33 @@ func TestReferenceParser(t *testing.T) { }) } } + +func BenchmarkSplitObject(b *testing.B) { + inputs := []string{ + "", + "@", + "docker.io@", + "@digest", + "docker.io/library/redis:foo?fooo=asdf", + "docker.io/library/redis:foo@sha256:abcdef?fooo=asdf", + "docker.io/library/redis@sha256:abcdef?fooo=asdf", + "docker.io/library/redis:obj@abcdef?fooo=asdf", + "localhost:5000/library/redis:obj@abcdef?fooo=asdf", + "/docker.io/library/redis:obj@abcdef?fooo=asdf", + "docker.io/library/redis?fooo=asdf", + "sub-dom1.foo.com/bar/baz/quux:latest", + "sub-dom1.foo.com/bar/baz/quux:some-long-tag", + "b.gcr.io/test.example.com/my-app:test.example.com", + "xn--n3h.com/myimage:xn--n3h.com", // ☃.com in punycode + "xn--7o8h.com/myimage:xn--7o8h.com@sha512:fffffff", + "http://xn--7o8h.com/myimage:xn--7o8h.com@sha512:fffffff", + } + + b.ReportAllocs() + + for i := 0; i < b.N; i++ { + for _, input := range inputs { + _, _ = SplitObject(input) + } + } +}