From 1921173569abaf115d6f6e82c091e1a92ace27e2 Mon Sep 17 00:00:00 2001 From: Stephen J Day Date: Tue, 27 Jun 2017 15:19:48 -0700 Subject: [PATCH] filters: handle presence syntax correctly Signed-off-by: Stephen J Day --- filters/filter_test.go | 9 +++++++++ filters/parser.go | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/filters/filter_test.go b/filters/filter_test.go index bcb4c43f8..f2e32cce8 100644 --- a/filters/filter_test.go +++ b/filters/filter_test.go @@ -112,6 +112,15 @@ func TestFilters(t *testing.T) { corpus[8], }, }, + { + name: "NameAndLabelPresent", + input: "labels.foo,name", + expected: []interface{}{ + corpus[0], + corpus[2], + corpus[8], + }, + }, { name: "LabelValue", input: "labels.foo==true", diff --git a/filters/parser.go b/filters/parser.go index 4d8e0d663..2f1366b01 100644 --- a/filters/parser.go +++ b/filters/parser.go @@ -99,7 +99,7 @@ func (p *parser) selector() (selector, error) { } switch p.scanner.peek() { - case tokenSeparator, tokenEOF: + case ',', tokenSeparator, tokenEOF: return selector{ fieldpath: fieldpath, operator: operatorPresent,