From 7f3bf993d64c3b91b5d1ab00b48d0ccbe5666714 Mon Sep 17 00:00:00 2001 From: Laura Brehm Date: Tue, 27 Aug 2024 23:48:54 +0100 Subject: [PATCH] runc-shim: remove misleading comment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's not true that `s.mu` needs to be held when calling `handleProcessExit`, and indeed hasn't been the case for a while – see 892dc54bd26f6e8b9aea4672208b1ba2158d8a1b. Signed-off-by: Laura Brehm --- cmd/containerd-shim-runc-v2/task/service.go | 1 - 1 file changed, 1 deletion(-) diff --git a/cmd/containerd-shim-runc-v2/task/service.go b/cmd/containerd-shim-runc-v2/task/service.go index b6455f285..1a1a960ff 100644 --- a/cmd/containerd-shim-runc-v2/task/service.go +++ b/cmd/containerd-shim-runc-v2/task/service.go @@ -707,7 +707,6 @@ func (s *service) send(evt interface{}) { s.events <- evt } -// s.mu must be locked when calling handleProcessExit func (s *service) handleProcessExit(e runcC.Exit, c *runc.Container, p process.Process) { if ip, ok := p.(*process.Init); ok { // Ensure all children are killed