Forward containerd debug to shim invocation
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
This commit is contained in:
@@ -53,6 +53,14 @@ type Shim interface {
|
||||
StartShim(ctx context.Context, id, containerdBinary, containerdAddress string) (string, error)
|
||||
}
|
||||
|
||||
// OptsKey is the context key for the Opts value.
|
||||
type OptsKey struct{}
|
||||
|
||||
// Opts are context options associated with the shim invocation.
|
||||
type Opts struct {
|
||||
Debug bool
|
||||
}
|
||||
|
||||
var (
|
||||
debugFlag bool
|
||||
idFlag string
|
||||
@@ -133,6 +141,7 @@ func run(id string, initFunc Init) error {
|
||||
return fmt.Errorf("shim namespace cannot be empty")
|
||||
}
|
||||
ctx := namespaces.WithNamespace(context.Background(), namespaceFlag)
|
||||
ctx = context.WithValue(ctx, OptsKey{}, Opts{Debug: debugFlag})
|
||||
ctx = log.WithLogger(ctx, log.G(ctx).WithField("runtime", id))
|
||||
|
||||
service, err := initFunc(ctx, idFlag, publisher)
|
||||
|
||||
39
runtime/v2/shim/shim_test.go
Normal file
39
runtime/v2/shim/shim_test.go
Normal file
@@ -0,0 +1,39 @@
|
||||
/*
|
||||
Copyright The containerd Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package shim
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestShimOptWithValue(t *testing.T) {
|
||||
ctx := context.TODO()
|
||||
ctx = context.WithValue(ctx, OptsKey{}, Opts{Debug: true})
|
||||
|
||||
o := ctx.Value(OptsKey{})
|
||||
if o == nil {
|
||||
t.Fatal("opts nil")
|
||||
}
|
||||
op, ok := o.(Opts)
|
||||
if !ok {
|
||||
t.Fatal("opts not of type Opts")
|
||||
}
|
||||
if !op.Debug {
|
||||
t.Fatal("opts.Debug should be true")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user