@@ -25,8 +25,7 @@ import (
|
||||
|
||||
"github.com/hashicorp/go-multierror"
|
||||
"github.com/pelletier/go-toml"
|
||||
"gotest.tools/v3/assert"
|
||||
is "gotest.tools/v3/assert/cmp"
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestLoadConfig(t *testing.T) {
|
||||
@@ -37,28 +36,27 @@ func TestLoadConfig(t *testing.T) {
|
||||
}
|
||||
|
||||
file, err := os.CreateTemp("", "devmapper-config-")
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
|
||||
encoder := toml.NewEncoder(file)
|
||||
err = encoder.Encode(&expected)
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
|
||||
defer func() {
|
||||
err := file.Close()
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
|
||||
err = os.Remove(file.Name())
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
}()
|
||||
|
||||
loaded, err := LoadConfig(file.Name())
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.Equal(t, loaded.RootPath, expected.RootPath)
|
||||
assert.Equal(t, loaded.PoolName, expected.PoolName)
|
||||
assert.Equal(t, loaded.BaseImageSize, expected.BaseImageSize)
|
||||
|
||||
assert.Assert(t, loaded.BaseImageSizeBytes == 128*1024*1024)
|
||||
assert.True(t, loaded.BaseImageSizeBytes == 128*1024*1024)
|
||||
}
|
||||
|
||||
func TestLoadConfigInvalidPath(t *testing.T) {
|
||||
@@ -66,7 +64,7 @@ func TestLoadConfigInvalidPath(t *testing.T) {
|
||||
assert.Equal(t, os.ErrNotExist, err)
|
||||
|
||||
_, err = LoadConfig("/dev/null")
|
||||
assert.Assert(t, err != nil)
|
||||
assert.NotNil(t, err)
|
||||
}
|
||||
|
||||
func TestParseInvalidData(t *testing.T) {
|
||||
@@ -81,15 +79,15 @@ func TestParseInvalidData(t *testing.T) {
|
||||
func TestFieldValidation(t *testing.T) {
|
||||
config := &Config{}
|
||||
err := config.Validate()
|
||||
assert.Assert(t, err != nil)
|
||||
assert.NotNil(t, err)
|
||||
|
||||
multErr := (err).(*multierror.Error)
|
||||
assert.Assert(t, is.Len(multErr.Errors, 4))
|
||||
assert.Len(t, multErr.Errors, 4)
|
||||
|
||||
assert.Assert(t, multErr.Errors[0] != nil, "pool_name is empty")
|
||||
assert.Assert(t, multErr.Errors[1] != nil, "root_path is empty")
|
||||
assert.Assert(t, multErr.Errors[2] != nil, "base_image_size is empty")
|
||||
assert.Assert(t, multErr.Errors[3] != nil, "filesystem type cannot be empty")
|
||||
assert.NotNil(t, multErr.Errors[0], "pool_name is empty")
|
||||
assert.NotNil(t, multErr.Errors[1], "root_path is empty")
|
||||
assert.NotNil(t, multErr.Errors[2], "base_image_size is empty")
|
||||
assert.NotNil(t, multErr.Errors[3], "filesystem type cannot be empty")
|
||||
}
|
||||
|
||||
func TestExistingPoolFieldValidation(t *testing.T) {
|
||||
@@ -101,5 +99,5 @@ func TestExistingPoolFieldValidation(t *testing.T) {
|
||||
}
|
||||
|
||||
err := config.Validate()
|
||||
assert.NilError(t, err)
|
||||
assert.NoError(t, err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user