vendor: update ttrpc for shutdown fix

Signed-off-by: Stephen J Day <stephen.day@docker.com>
This commit is contained in:
Stephen J Day 2018-01-09 16:13:43 -08:00
parent 29ddd3d5fb
commit 87cb12de32
No known key found for this signature in database
GPG Key ID: 67B3DED84EDC823F
3 changed files with 48 additions and 3 deletions

View File

@ -40,4 +40,4 @@ github.com/boltdb/bolt e9cf4fae01b5a8ff89d0ec6b32f0d9c9f79aefdd
google.golang.org/genproto d80a6e20e776b0b17a324d0ba1ab50a39c8e8944 google.golang.org/genproto d80a6e20e776b0b17a324d0ba1ab50a39c8e8944
golang.org/x/text 19e51611da83d6be54ddafce4a4af510cb3e9ea4 golang.org/x/text 19e51611da83d6be54ddafce4a4af510cb3e9ea4
github.com/dmcgowan/go-tar go1.10 github.com/dmcgowan/go-tar go1.10
github.com/stevvooe/ttrpc 76e68349ad9ab4d03d764c713826d31216715e4f github.com/stevvooe/ttrpc d2710463e497617f16f26d1e715a3308609e7982

View File

@ -2,8 +2,12 @@ package ttrpc
import ( import (
"context" "context"
"io"
"net" "net"
"os"
"strings"
"sync" "sync"
"syscall"
"github.com/containerd/containerd/log" "github.com/containerd/containerd/log"
"github.com/gogo/protobuf/proto" "github.com/gogo/protobuf/proto"
@ -11,6 +15,10 @@ import (
"google.golang.org/grpc/status" "google.golang.org/grpc/status"
) )
// ErrClosed is returned by client methods when the underlying connection is
// closed.
var ErrClosed = errors.New("ttrpc: closed")
type Client struct { type Client struct {
codec codec codec codec
conn net.Conn conn net.Conn
@ -91,7 +99,7 @@ func (c *Client) dispatch(ctx context.Context, req *Request, resp *Response) err
select { select {
case err := <-errs: case err := <-errs:
return err return filterCloseErr(err)
case <-c.done: case <-c.done:
return c.err return c.err
} }
@ -171,7 +179,14 @@ func (c *Client) run() {
call.errs <- c.recv(call.resp, msg) call.errs <- c.recv(call.resp, msg)
delete(waiters, msg.StreamID) delete(waiters, msg.StreamID)
case <-shutdown: case <-shutdown:
if shutdownErr != nil {
shutdownErr = filterCloseErr(shutdownErr)
} else {
shutdownErr = ErrClosed
}
shutdownErr = errors.Wrapf(shutdownErr, "ttrpc: client shutting down") shutdownErr = errors.Wrapf(shutdownErr, "ttrpc: client shutting down")
c.err = shutdownErr c.err = shutdownErr
for _, waiter := range waiters { for _, waiter := range waiters {
waiter.errs <- shutdownErr waiter.errs <- shutdownErr
@ -179,6 +194,9 @@ func (c *Client) run() {
c.Close() c.Close()
return return
case <-c.closed: case <-c.closed:
if c.err == nil {
c.err = ErrClosed
}
// broadcast the shutdown error to the remaining waiters. // broadcast the shutdown error to the remaining waiters.
for _, waiter := range waiters { for _, waiter := range waiters {
waiter.errs <- shutdownErr waiter.errs <- shutdownErr
@ -209,3 +227,30 @@ func (c *Client) recv(resp *Response, msg *message) error {
defer c.channel.putmbuf(msg.p) defer c.channel.putmbuf(msg.p)
return proto.Unmarshal(msg.p, resp) return proto.Unmarshal(msg.p, resp)
} }
// filterCloseErr rewrites EOF and EPIPE errors to ErrClosed. Use when
// returning from call or handling errors from main read loop.
//
// This purposely ignores errors with a wrapped cause.
func filterCloseErr(err error) error {
if err == nil {
return nil
}
if err == io.EOF {
return ErrClosed
}
if strings.Contains(err.Error(), "use of closed network connection") {
return ErrClosed
}
// if we have an epipe on a write, we cast to errclosed
if oerr, ok := err.(*net.OpError); ok && oerr.Op == "write" {
if serr, ok := oerr.Err.(*os.SyscallError); ok && serr.Err == syscall.EPIPE {
return ErrClosed
}
}
return err
}

View File

@ -16,7 +16,7 @@ import (
) )
var ( var (
ErrServerClosed = errors.New("ttrpc: server close") ErrServerClosed = errors.New("ttrpc: server closed")
) )
type Server struct { type Server struct {