Don't build a second copy of containerd-shim-runhcs-v1.exe
`make binaries` already builds containerd-shim-runhcs-v1.exe next to containerd.exe, so there's no need to spend time checking out and building it again. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This commit is contained in:
		
							
								
								
									
										11
									
								
								.github/workflows/ci.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										11
									
								
								.github/workflows/ci.yml
									
									
									
									
										vendored
									
									
								
							| @@ -254,11 +254,6 @@ jobs: | |||||||
|         with: |         with: | ||||||
|           path: src/github.com/containerd/containerd |           path: src/github.com/containerd/containerd | ||||||
|  |  | ||||||
|       - uses: actions/checkout@v2 |  | ||||||
|         with: |  | ||||||
|           repository: Microsoft/hcsshim |  | ||||||
|           path: src/github.com/Microsoft/hcsshim |  | ||||||
|  |  | ||||||
|       - uses: actions/checkout@v2 |       - uses: actions/checkout@v2 | ||||||
|         with: |         with: | ||||||
|           repository: kubernetes-sigs/cri-tools |           repository: kubernetes-sigs/cri-tools | ||||||
| @@ -279,12 +274,6 @@ jobs: | |||||||
|         run: | |         run: | | ||||||
|           set -o xtrace |           set -o xtrace | ||||||
|           mingw32-make.exe binaries |           mingw32-make.exe binaries | ||||||
|           bindir="$(pwd)" |  | ||||||
|           SHIM_COMMIT=$(grep 'Microsoft/hcsshim ' go.mod | awk '{print $2}') |  | ||||||
|           cd ../../Microsoft/hcsshim |  | ||||||
|           git fetch --tags origin "${SHIM_COMMIT}" |  | ||||||
|           git checkout "${SHIM_COMMIT}" |  | ||||||
|           GO111MODULE=on go build -mod=vendor -o "${bindir}/integration/client/containerd-shim-runhcs-v1.exe" ./cmd/containerd-shim-runhcs-v1 |  | ||||||
|           cd ../../kubernetes-sigs/cri-tools |           cd ../../kubernetes-sigs/cri-tools | ||||||
|           make critest |           make critest | ||||||
|  |  | ||||||
|   | |||||||
							
								
								
									
										7
									
								
								.github/workflows/windows-periodic.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										7
									
								
								.github/workflows/windows-periodic.yml
									
									
									
									
										vendored
									
									
								
							| @@ -150,13 +150,6 @@ jobs: | |||||||
|         run: | |         run: | | ||||||
|           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "git clone http://github.com/containerd/containerd c:\\containerd " |           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "git clone http://github.com/containerd/containerd c:\\containerd " | ||||||
|           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "cd c:\containerd ; make binaries" |           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "cd c:\containerd ; make binaries" | ||||||
|           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "git clone http://github.com/Microsoft/hcsshim c:\containerd\hcsshim " |  | ||||||
|  |  | ||||||
|           # Get shim commit from containerd local repo |  | ||||||
|           SHIM_COMMIT=$(grep 'Microsoft/hcsshim' go.mod | awk '{ print $2 }'); |  | ||||||
|  |  | ||||||
|           ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "cd c:\containerd\hcsshim; git fetch --tags origin $SHIM_COMMIT ; \ |  | ||||||
|                             git checkout $SHIM_COMMIT ; go build -mod=vendor -o ${{ env.REMOTE_VM_BIN_PATH }}\containerd-shim-runhcs-v1.exe .\cmd\containerd-shim-runhcs-v1" |  | ||||||
|  |  | ||||||
|       - name: RunIntegrationTests |       - name: RunIntegrationTests | ||||||
|         run: | |         run: | | ||||||
|   | |||||||
		Reference in New Issue
	
	Block a user
	 Paul "TBBle" Hampson
					Paul "TBBle" Hampson