From 9639db5522d252a6bff43ca9dbc2a6c1dbdd078e Mon Sep 17 00:00:00 2001 From: Michael Wan Date: Mon, 19 Nov 2018 09:41:38 -0500 Subject: [PATCH] refactor: no need defer in closeAll Signed-off-by: Michael Wan --- events/exchange/exchange.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/events/exchange/exchange.go b/events/exchange/exchange.go index 95d21b7df..39972d74b 100644 --- a/events/exchange/exchange.go +++ b/events/exchange/exchange.go @@ -138,10 +138,10 @@ func (e *Exchange) Subscribe(ctx context.Context, fs ...string) (ch <-chan *even ) closeAll := func() { - defer close(errq) - defer e.broadcaster.Remove(dst) - defer queue.Close() - defer channel.Close() + channel.Close() + queue.Close() + e.broadcaster.Remove(dst) + close(errq) } ch = evch