Merge pull request #1028 from crosbymichael/content-codes
Don't log AlreadyExists errors
This commit is contained in:
commit
966ceb2c9a
@ -238,6 +238,7 @@ func (s *Service) Write(session api.Content_WriteServer) (err error) {
|
||||
defer func(msg *api.WriteResponse) {
|
||||
// pump through the last message if no error was encountered
|
||||
if err != nil {
|
||||
if grpc.Code(err) != codes.AlreadyExists {
|
||||
// TODO(stevvooe): Really need a log line here to track which
|
||||
// errors are actually causing failure on the server side. May want
|
||||
// to configure the service with an interceptor to make this work
|
||||
@ -245,6 +246,7 @@ func (s *Service) Write(session api.Content_WriteServer) (err error) {
|
||||
//
|
||||
// This is pretty noisy, so we can remove it but leave it for now.
|
||||
log.G(ctx).WithError(err).Error("(*Service).Write failed")
|
||||
}
|
||||
|
||||
return
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user