From 98f5922b5e27f5e1d4e398091c6f2c24eea203dd Mon Sep 17 00:00:00 2001 From: Iceber Gu Date: Fri, 30 Apr 2021 23:32:04 +0800 Subject: [PATCH] plugin: optimize the check for the last registration Signed-off-by: Iceber Gu --- plugin/plugin.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/plugin/plugin.go b/plugin/plugin.go index 2674edeb1..1894afe8c 100644 --- a/plugin/plugin.go +++ b/plugin/plugin.go @@ -171,15 +171,11 @@ func Register(r *Registration) { panic(err) } - var last bool for _, requires := range r.Requires { - if requires == "*" { - last = true + if requires == "*" && len(r.Requires) != 1 { + panic(ErrInvalidRequires) } } - if last && len(r.Requires) != 1 { - panic(ErrInvalidRequires) - } register.r = append(register.r, r) }