From 9d72b4543b57e85b5a7f60d69df7e00433e8feae Mon Sep 17 00:00:00 2001 From: Michael Crosby Date: Thu, 26 Jul 2018 11:24:20 -0400 Subject: [PATCH] Handle windows signals Since windows does not require a signal handler, we just block on the channel forever so that it does not exit. Signed-off-by: Michael Crosby --- runtime/v2/shim/shim_windows.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/runtime/v2/shim/shim_windows.go b/runtime/v2/shim/shim_windows.go index 7827b25ad..0f1616a35 100644 --- a/runtime/v2/shim/shim_windows.go +++ b/runtime/v2/shim/shim_windows.go @@ -37,7 +37,6 @@ import ( // setupSignals creates a new signal handler for all signals func setupSignals() (chan os.Signal, error) { signals := make(chan os.Signal, 32) - // TODO: JTERRY75: Make this based on events. return signals, nil } @@ -67,7 +66,7 @@ func serveListener(path string) (net.Listener, string, error) { } func handleSignals(logger *logrus.Entry, signals chan os.Signal) error { - // TODO: JTERRY75: Make this based on events? + <-signals return nil }