Merge pull request #9230 from mxpv/exit

Exit shim when shutdown manager is done
This commit is contained in:
Akihiro Suda 2023-10-13 14:51:20 +09:00 committed by GitHub
commit 9fcc3beb59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -379,7 +379,7 @@ func run(ctx context.Context, manager Manager, name string, config Config) error
}
if err := serve(ctx, server, signals, sd.Shutdown); err != nil {
if err != shutdown.ErrShutdown {
if !errors.Is(err, shutdown.ErrShutdown) {
return err
}
}
@ -391,10 +391,10 @@ func run(ctx context.Context, manager Manager, name string, config Config) error
}
select {
case <-publisher.Done():
case <-sd.Done():
return nil
case <-time.After(5 * time.Second):
return errors.New("publisher not closed")
return errors.New("shim shutdown timeout")
}
}