github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Merge pull request #7629 from wzshiming/feat/pprof-debug

Browse Source 
Add `--debug` args to all subcommands of `ctr pprof`
This commit is contained in:
Fu Wei 2022-11-11 11:47:57 +08:00 committed by GitHub
commit 9fffa8c712
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 50 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
cmd/ctr/commands/pprof/pprof.go
View File

@ -56,10 +56,18 @@ var Command = cli.Command{
var pprofGoroutinesCommand = cli.Command{ var pprofGoroutinesCommand = cli.Command{
Name: "goroutines", Name: "goroutines",
Usage: "dump goroutine stack dump", Usage: "dump goroutine stack dump",
Flags: []cli.Flag{
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 2,
},
},
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
output, err := httpGetRequest(client, "/debug/pprof/goroutine?debug=2") debug := context.Uint("debug")
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/goroutine?debug=%d", debug))
if err != nil { if err != nil {
return err return err
} }
@ -72,10 +80,18 @@ var pprofGoroutinesCommand = cli.Command{
var pprofHeapCommand = cli.Command{ var pprofHeapCommand = cli.Command{
Name: "heap", Name: "heap",
Usage: "dump heap profile", Usage: "dump heap profile",
Flags: []cli.Flag{
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 0,
},
},
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
output, err := httpGetRequest(client, "/debug/pprof/heap") debug := context.Uint("debug")
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/heap?debug=%d", debug))
if err != nil { if err != nil {
return err return err
} }
@ -94,12 +110,18 @@ var pprofProfileCommand = cli.Command{
Usage: "duration for collection (seconds)", Usage: "duration for collection (seconds)",
Value: 30 * time.Second, Value: 30 * time.Second,
}, },
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 0,
},
}, },
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
seconds := context.Duration("seconds").Seconds() seconds := context.Duration("seconds").Seconds()
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/profile?seconds=%v", seconds)) debug := context.Uint("debug")
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/profile?seconds=%v&debug=%d", seconds, debug))
if err != nil { if err != nil {
return err return err
} }
@ -118,12 +140,18 @@ var pprofTraceCommand = cli.Command{
Usage: "trace time (seconds)", Usage: "trace time (seconds)",
Value: 5 * time.Second, Value: 5 * time.Second,
}, },
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 0,
},
}, },
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
seconds := context.Duration("seconds").Seconds() seconds := context.Duration("seconds").Seconds()
uri := fmt.Sprintf("/debug/pprof/trace?seconds=%v", seconds) debug := context.Uint("debug")
uri := fmt.Sprintf("/debug/pprof/trace?seconds=%v&debug=%d", seconds, debug)
output, err := httpGetRequest(client, uri) output, err := httpGetRequest(client, uri)
if err != nil { if err != nil {
return err return err
@ -137,10 +165,18 @@ var pprofTraceCommand = cli.Command{
var pprofBlockCommand = cli.Command{ var pprofBlockCommand = cli.Command{
Name: "block", Name: "block",
Usage: "goroutine blocking profile", Usage: "goroutine blocking profile",
Flags: []cli.Flag{
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 0,
},
},
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
output, err := httpGetRequest(client, "/debug/pprof/block") debug := context.Uint("debug")
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/block?debug=%d", debug))
if err != nil { if err != nil {
return err return err
} }
@ -153,10 +189,18 @@ var pprofBlockCommand = cli.Command{
var pprofThreadcreateCommand = cli.Command{ var pprofThreadcreateCommand = cli.Command{
Name: "threadcreate", Name: "threadcreate",
Usage: "goroutine thread creating profile", Usage: "goroutine thread creating profile",
Flags: []cli.Flag{
cli.UintFlag{
Name: "debug",
Usage: "debug pprof args",
Value: 0,
},
},
Action: func(context *cli.Context) error { Action: func(context *cli.Context) error {
client := getPProfClient(context) client := getPProfClient(context)
output, err := httpGetRequest(client, "/debug/pprof/threadcreate") debug := context.Uint("debug")
output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/threadcreate?debug=%d", debug))
if err != nil { if err != nil {
return err return err
} }