github/containerd
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fs/diff: support symlink to abspath with second-precision mtime

Browse Source 
Previously, `Changes()` for a symlink to absolute path, with second-precision
mtime of the link itself always resulted in ENOENT.

This is because `compareFileContent()` was called for the link target path, without changing the root path.

Fix moby/buildkit#172

Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
This commit is contained in:
Akihiro Suda
2017-11-20 09:14:48 +00:00
parent 1bd39d36ed
commit a3aeb398fe
5 changed files with 88 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
fs/fstest/file.go
View File

@@ -71,10 +71,11 @@ func Chown(name string, uid, gid int) Applier {
})
}
// Chtime changes access and mod time of file
func Chtime(name string, t time.Time) Applier {
// Chtimes changes access and mod time of file.
// Use Lchtimes for symbolic links.
func Chtimes(name string, atime, mtime time.Time) Applier {
return applyFn(func(root string) error {
return os.Chtimes(filepath.Join(root, name), t, t)
return os.Chtimes(filepath.Join(root, name), atime, mtime)
})
}