github/containerd
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Disable TestContainerHook on Windows

Browse Source 
OCI hooks aren't implemented on Windows. The test will, and has been,
actuallyrunning fine on Windows because the Github runners seem to have
a 'ps' binary in the users PATH, but there's not any actual hook
functionality being tested as any of the OCI fields are ignored for
Windows containers.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
This commit is contained in:
Daniel Canter 2021-12-14 17:05:07 -08:00
parent 3c3486f91b
commit abcf7c2f6a
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
integration/client/container_test.go
View File

@ -1569,6 +1569,12 @@ func TestContainerLabels(t *testing.T) {
} }
func TestContainerHook(t *testing.T) { func TestContainerHook(t *testing.T) {
// OCI hooks aren't implemented on Windows. This test will actually run fine on Windows if there's a 'ps' binary in the users PATH, but
// there's not any actual hook functionality being tested as any of the OCI fields are plain ignored for Windows containers.
if runtime.GOOS == "windows" {
t.Skip()
}
t.Parallel() t.Parallel()
client, err := newClient(t, address) client, err := newClient(t, address)