From ace1912bbaf468c0b960df2191a375b2b48823a5 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Tue, 23 Mar 2021 11:35:05 +0100 Subject: [PATCH] sys: use assert for error checks in OOM tests Slightly easier to read, and we were already using assert in this file Signed-off-by: Sebastiaan van Stijn --- sys/oom_linux_test.go | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/sys/oom_linux_test.go b/sys/oom_linux_test.go index dcc0ceddd..adb655320 100644 --- a/sys/oom_linux_test.go +++ b/sys/oom_linux_test.go @@ -31,10 +31,7 @@ import ( func TestSetPositiveOomScoreAdjustment(t *testing.T) { // Setting a *positive* OOM score adjust does not require privileged _, adjustment, err := adjustOom(123) - if err != nil { - t.Error(err) - return - } + assert.NilError(t, err) assert.Check(t, is.Equal(adjustment, 123)) } @@ -45,10 +42,7 @@ func TestSetNegativeOomScoreAdjustmentWhenPrivileged(t *testing.T) { } _, adjustment, err := adjustOom(-123) - if err != nil { - t.Error(err) - return - } + assert.NilError(t, err) assert.Check(t, is.Equal(adjustment, -123)) } @@ -59,10 +53,7 @@ func TestSetNegativeOomScoreAdjustmentWhenUnprivilegedHasNoEffect(t *testing.T) } initial, adjustment, err := adjustOom(-123) - if err != nil { - t.Error(err) - return - } + assert.NilError(t, err) assert.Check(t, is.Equal(adjustment, initial)) }